]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
util: Always use 12h format if requested
authorFlorian Müllner <fmuellner@gnome.org>
Sun, 21 May 2017 19:12:49 +0000 (21:12 +0200)
committerFlorian Müllner <fmuellner@gnome.org>
Mon, 22 May 2017 13:41:29 +0000 (15:41 +0200)
Whether we show times in 12h format currently depends on:
 - the 'clock-format' desktop setting
 - the locale support for AM/PM

This was consist with other GNOME components, however both the
WallClock[0] and the Date+Time Settings panel[1] dropped the
second check after GDateTime started supporting AM/PM independently
from the locale, so we should follow suite.

[0] https://git.gnome.org/browse/gnome-desktop/commit?id=226fe725ef2cb2
[1] https://git.gnome.org/browse/gnome-control-center/commit?id=85cd910af

https://bugzilla.gnome.org/show_bug.cgi?id=782930

configure.ac
js/misc/util.js

index ffbc1a4cada2990c281a7b2531345c2ad2775f49..8f19ad3c332704dd05dab6ef66b9e1c913837d2d 100644 (file)
@@ -87,7 +87,7 @@ GOBJECT_INTROSPECTION_MIN_VERSION=1.49.1
 GJS_MIN_VERSION=1.47.0
 MUTTER_MIN_VERSION=3.25.1
 GTK_MIN_VERSION=3.15.0
-GIO_MIN_VERSION=2.45.3
+GIO_MIN_VERSION=2.53.0
 LIBECAL_MIN_VERSION=3.5.3
 LIBEDATASERVER_MIN_VERSION=3.17.2
 POLKIT_MIN_VERSION=0.100
index d4026e27b49cd4bc3736d1e1d6e23ecd60097771..e9aa9ef8a7d0822d2c60abe444ecab67aaa1bcbd 100644 (file)
@@ -218,11 +218,10 @@ function formatTime(time, params) {
     if (_desktopSettings == null)
         _desktopSettings = new Gio.Settings({ schema_id: 'org.gnome.desktop.interface' });
     let clockFormat = _desktopSettings.get_string('clock-format');
-    let hasAmPm = date.format('%p') != '';
 
     params = Params.parse(params, { timeOnly: false });
 
-    if (clockFormat == '24h' || !hasAmPm) {
+    if (clockFormat == '24h') {
         // Show only the time if date is on today
         if (daysAgo < 1 || params.timeOnly)
             /* Translators: Time in 24h format */